Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unlock will switch to greeter #14

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

justforlxz
Copy link
Member

as title

Log:

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Display::slotHelperFinished函数中,当m_displayServerType不等于DisplayServerType::SingleCompositerServerType时,应该调用stop()函数,以确保进程正确地停止。
  • SingleWaylandDisplayServer::activateUser函数中,对于user为"dde"的情况,应该调用displayPtr()->activateUser(user),而不是displayPtr()->activateUser(user) // IOCTL activate
  • SingleWaylandDisplayServer::onLoginFailedSingleWaylandDisplayServer::onLoginSucceeded函数中,应该遍历m_greeterSockets而不是只使用第一个greeter
  • SingleWaylandDisplayServer::getUserWaylandSocket函数中,应该检查m_waylandSockets.value(user)是否存在,以避免潜在的空指针异常。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Groveer Groveer merged commit e2ae98b into linuxdeepin:master Jul 25, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants